Collective development of a server for variants

Lighthouse (renamed) (#344)

main ← fog_of_war

opened 09:03PM - 24 Nov 24 UTC

+543 -0

This is a prototype for a variant where hidden information is the main quirk. Ba…sically what we discussed in the forum but additionally with "last known information". The board is hidden, but stones cast rays that illuminate fields for their owner only. Any field that is not illuminated displays its last known information. I'm trying to build it such that the observer view does not reveal any information to players. I'm not sure how to handle Ko and Self-Capture yet, since players could gain information when they receive an Error and can play another move. ![grafik](https://github.com/user-attachments/assets/e92da302-1a12-47f0-99fc-765a96dd4bd9) I've added the possibility to change the background colour of specific fields to MulticolorGridBoard, and a new board component that uses it. I'm not sure if this is good tbh, but I wanted it to test the game class. Also not sure if fog of war is a good name.

Super Tic Tac Go

board patterns

sunflower

custom graph

Custom graph (#396)

main ← custom-graphh

opened 04:59AM - 12 Apr 25 UTC

+366 -3

Fixes #111 Need to do some more testing, but basically this one allows arbit…rary adjacency lists I guess the biggest thing that we need to get right at the beginning is the input format. Does this seem reasonable? ``` { "coordinates": [[0, 0], [0, 1], [1, 0], [1, 1]], "adjacencyList": [[1, 2], [0, 3], [0, 3], [1, 2]] } ``` ## Screenshots <img width="424" alt="Screenshot 2025-04-12 at 2 38 13 PM" src="https://github.com/user-attachments/assets/f578723a-380f-4819-a585-af456fbff7da" /> <img width="551" alt="Screenshot 2025-04-12 at 2 36 42 PM" src="https://github.com/user-attachments/assets/840810c7-70ca-49d3-bf13-1d3ea0c30ac0" /> <img width="697" alt="Screenshot 2025-04-12 at 2 37 31 PM" src="https://github.com/user-attachments/assets/d21ab320-a3b5-48b7-8865-5a90e536e7b5" />

ratings

Rating system (#332)

main ← rating-system

opened 08:44PM - 15 Nov 24 UTC

SameerDalal

+284 -9

Created the first version of the rating system. Currently, the user ratings a…re updated after every match, which is not ideal according to the glicko2 library. Instead, after a match, I want to add the result to the `matches` array and then store the array somewhere in the database. Then when the `matches` array has 10 elements, we can update the ratings and clear the array. So my question is where in the database should I store the `matches` array?

rule descriptions & demo

Rules List (#340)

main ← add_demo_board_to_rules_page

opened 09:05PM - 22 Nov 24 UTC

+100 -20

This adds a new view that is linked to in the NavBar and has links to the rules …page for variants with a (detailed) rules description. Also I've added the demo board to the rules view as proposed in https://github.com/govariantsteam/govariants/issues/112 I wasn't able to make sure that the demo board fits, so I made its container scrollable on overflow. ### Rules List ![grafik](https://github.com/user-attachments/assets/85a401e5-ae46-4f67-a6db-ce413568dcc1) ![grafik](https://github.com/user-attachments/assets/a33090fd-c8f3-4ab5-9648-70c0e87e7649) ![grafik](https://github.com/user-attachments/assets/f6919006-c6bc-439d-b3b1-cc7d6c0454df) ### Rules Page ![grafik](https://github.com/user-attachments/assets/6bb506a7-96dc-4936-bfd3-ccfc256c527f) ![grafik](https://github.com/user-attachments/assets/60311ac3-8eb0-4175-af15-65d672439608)

default board

Add a default board (#322)

main ← flex-board

opened 04:10AM - 09 Nov 24 UTC

+208 -139

Based on discussion on #137, this is a proposal to replace Board .vue files with… a simple JS function. It's a larger PR, so to summarize: - Introduce `DefaultBoard` (a selector for MulticolorGridBoard and MulticolorGraphBoard) - Introduce `uiTransform` (a function that can update the config and state to fit the DefaultBoard interface) - To validate, migrate `FreezeGo` to the `DefaultBoard` and test. Testing: Freeze go and other variants seem to show up fine in the game list, game view, and demo view. For example, here is the demo view: ![Screenshot_20241108_225559](https://github.com/user-attachments/assets/5d513a49-056d-4d63-b961-c8f2ca629436)

Migrate Baduk (and subvariants) to the DefaultBoard (#327)

main ← migrate-baduk

opened 12:17AM - 13 Nov 24 UTC

+117 -300

The main change is the addition of `uiTransform` to `baduk.ts` and deletion of t…he three boards in vue-client/src/components/boards, but there are a bunch of knock-on effects because so many variants are built on top of this variant. I'll try to comment on seemingly unrelated changes in this diff. **Tested:** I spot checked affected variants ![Screenshot_20241112_191002](https://github.com/user-attachments/assets/01a2a046-767c-49ac-a1f9-3b1f434de87c) ![Screenshot_20241112_190844](https://github.com/user-attachments/assets/a6b03bc6-56ec-4f97-9b10-fbb54a06e88c)

Migrate QuantumBoard to DefaultBoard (#328)

main ← quantum-migration

opened 11:33PM - 14 Nov 24 UTC

+57 -100

https://github.com/govariantsteam/govariants/pull/327#discussion_r1842799084 …The major benefit is that we're able to remove some duplicate codepaths for Grid and Graph boards. I did fudge types quite a bit, so I'm open to ideas on improvement, but overall, it works, and I think the reduction in code (~50 lines) is worth it. Tested: both grid and graph boards ![Screenshot_20241114_182904](https://github.com/user-attachments/assets/d8a2469e-1436-493d-8b25-09abd9d25b42) Forgot to screnshot grid, but I promise I tested that too :)

migrate sfractional to default board (#330)

main ← migrate_sfractional_board

opened 04:05PM - 15 Nov 24 UTC

+51 -164

This makes it so SFractional also uses the DefaultBoard component. Regarding the… playing table, it works to have the uiTransform return an extended type (thanks for the suggestion @benjaminpjones !), and I think I found a relatively nice way to indicate the types. relates to https://github.com/govariantsteam/govariants/issues/137

Last move indicator in UI transform (#371)

main ← last_move_indicator_in_ui_transform

opened 05:37PM - 06 Jan 25 UTC

+70 -21

Issue: #137 - circle annotation uses mix-blend-mode: difference - enable the …annotation in variants baduk, sfractional - fix annotation in graph board ![grafik](https://github.com/user-attachments/assets/b3923358-d090-4b08-ad13-9150aab901fe) ![grafik](https://github.com/user-attachments/assets/cc9b498a-138a-4869-8076-810a302fcc3c)

admin role

Admin role (#345)

main ← admin2

opened 11:12PM - 24 Nov 24 UTC

+139 -14

This adds the admin role and one elevated privilege: the ability to make another… user an admin. [Screencast_20241123_232459.webm](https://github.com/user-attachments/assets/ad96e336-901f-4a88-9231-f76dc22e4e03) A couple required, but not directly related changes: - Created User page, where we add the "Make Admin" button - Fixed up some User types: - `id` should be required in `UserResponse`, except for DB code - Some instances of `User`changed to `UserResponse`. - I think these are generally interchangeable (except for the optional id issue). I should follow up to merge the two.

Add admin mode to games page, and allow admins to kick users (#367)

main ← kick-user

opened 11:28PM - 31 Dec 24 UTC

+46 -9

This adds a little toggle on the games page for admins that allows them to use s…pecial powers. It's off-by-default, so admins can enjoy games as normal users. This PR also adds the power to kick a user from their seat. ![Screenshot of admin mode](https://github.com/user-attachments/assets/7be908dc-2ded-4204-8442-23a94159ea1b) https://github.com/user-attachments/assets/2c7cd98b-c80e-487d-af68-ea66066309f1

Allow admins to delete users (#368)

main ← delete-users

opened 01:22AM - 01 Jan 25 UTC

+78 -19

Basically what the title says. Additionally, I pulled in the [sweetalert2](http…s://sweetalert2.github.io) library. This gives us ability to launch more advanced modals than `window.alert()`, which was necessary for the additional verification in the User deletion flow. 0) Log in as admin 1) Click "Delete User" 2) Enter user's name as a safeguard ![Screenshot_20241231_195147](https://github.com/user-attachments/assets/401b4eea-b25d-46d7-8ff6-7fcfbda40b49) 3a) On failure, inform the admin ![Screenshot_20241231_195215](https://github.com/user-attachments/assets/171b3ff7-3238-4034-adb2-a0dfae22062a) 3b) On success, inform the admin, then return home ![Screenshot_20241231_195239](https://github.com/user-attachments/assets/63b50536-8527-48bf-aaf6-93da16a224a2)

board preview

show who hasn’t played yet in parallel variants

[fractional] only include unstaged players in nextToPlay (#381)

main ← next-to-play-2

opened 03:05AM - 30 Mar 25 UTC

+10 -3

Currently, we list every player in `nextToPlay` because, technically, all player…s may move. I propose we exclude staged players since they are not required to play again in the round. Motivation: I believe this will be useful in [Forums game](https://www.govariants.com/game/670952d842e74078c7a967fe) where players have often not realized they were holding up the round. If this change is agreeable, I'm happy to follow up and update all the parallel variants. ## Testing Manually, I tried a fractional game, and observed: a) players are still able to edit their moves for the duration of the round b) only unstaged players are listed in the "Players to move" component https://github.com/user-attachments/assets/c5eb156f-8eae-4c35-881d-76a4e18fa5c9

Update parallel.ts to exclude unstaged players from nextToMove() (#385)

main ← parallel-next-to-move

opened 06:08PM - 30 Mar 25 UTC

+31 -41

- `Indexes` -> `Indices`, move `getNullIndices()` into utils - Tbh I though…t we had more than 2 parallel variants, hence the move to utils. - `parallel` to take the same `nextToMove` approach as `fractional` (see #381) Tested: - unit tests caught a lot! - manually checked the parallel variant

CSRF-protection

CSRF protection (#390)

main ← csfr_protection

opened 01:52PM - 03 Apr 25 UTC

+80 -11

issue: #346 Based on [https://medium.com/@brakdemir/csrf-prevention-on-node-…js-express-without-csurf-da5d9e6272ad](url) using the Synchronizer Token Pattern This is my attempt to add a system that protects us again Cross Site Request Forgery. With CheckLogin, a random token is generated, stored in the users session, and sent in the response body. The client then sends this token in all requests header, and the server compares it to what was stored in session.

Graph boards in variant pyramid

Generalised pyramid counting (#408)

main ← generalised_pyramid_counting

opened 02:50PM - 27 Apr 25 UTC

+300 -44

# Proposed Changes - Add graph utils including a function to calculate generali…sed pyramid weights - Refactor variant Pyramid s.t. it supports graph boards (grid board uses the classical weights schema) - Weights are calculated once on client and stored in config - Fix a bug of voronoi diagram # Note - I noticed that the voronoi calculations sometimes crash, e.g. with sunflower board. I'll try to fix that. ![grafik](https://github.com/user-attachments/assets/72be1154-23ca-4936-8d72-3d789febc4ae)

Maintainance & Documentation

cleanup deprecated variant BadukWithAbstractBoard

cleanup BadukWithAbstractBoard, move files, fix imports (#318)

main ← old_stuff_cleanup

opened 10:16AM - 04 Nov 24 UTC

+25 -215

Sorry for the big diff. This is a bunch of cleanup of old stuff. - Delete dea…d code: BadukBoardAbstract (was used before we had the board factory), IBadukBoard, StoneState, BadukWithAbstractBoardConfigForm - Move board creation helpers into lib/abstractBoard/helper - Move BadukWithAbstractBoard into variants/deprecated - Export / Import fixes

lint rules

commit hooks

Add husky (git commit hooks) (#348)

main ← husky

opened 02:18AM - 27 Nov 24 UTC

+18 -1

Fixes #290 Git hooks is something I find personally useful, and I notice a l…ot of "fix lints" commits so I wonder if it would help others too. If you think this would be a bother, let me know and we can make it opt-in (likely by removing it from the "postinstall" script.) A couple things to know about using husky: - If we call it in "postinstall" it will be propagated to all developers during `yarn` install - Devs can add `-n`/`--no-verify` flag during `git commit` to skip the check

Optimize pre-commit (#362)

main ← lint-staged

opened 07:22PM - 14 Dec 24 UTC

+363 -8

## Problem Statement pre-commit check currently: - is slow (>30s on my mac…hine) - checks all changes, even if they aren't staged - performs write operations ## Proposed Changes - Use [lint-staged](https://github.com/lint-staged/lint-staged?tab=readme-ov-file#configuration) - Just lint, skip tests - Run read-only operations (e.g. `--check` instead of `--write`) ## Benchmarks On my machine (Intel Core i5-8250U CPU @ 1.60GHz), I have these times after staging changes for a single file: - `yarn lint`: ~14s - `yarn test`: ~20s - `yarn lint-staged`: ~6s Therefore, we have a roughly 5x speedup, though it will depend heavily on the machine and staged files.

update dependencies

Upgrade ws (#354)

main ← upgrade-ws

opened 03:45PM - 30 Nov 24 UTC

+640 -379

ws is a transitive dependency via socket.io and jsdom. There is a security vulne…rability (CVE-2024-37890, https://github.com/advisories/GHSA-3h5v-q93c-6h6q) affecting <8.17.1 causing DoS when handling a request with many HTTP headers. I was able to remove our dependence on jsdom. The vulnerability was handled in socket.io so I upgraded that as well. ## Changes - Upgrade socket.io in both server/ and vue-client/ (4.7.1 -> 4.8.1) - Added yarn plugin `upgrade-interactive` - not strictly required for this PR, but it helps with version upgrades - Removed jsdom and associated scripts - needed to keep @types/jsdom to prevent TS from complaining about browser APIs, but I moved it to the right package (server -> vue-client) ## Tested Deploy scripts still work: ``` yarn build NODE_ENV=production yarn workspace @ogfcommunity/variants-server launch ``` And we can verify that ws is upgraded using `yarn why` (note all ws are at 8.17.1): ``` ├─ @ogfcommunity/variants-server@workspace:packages/server │ └─ socket.io@npm:4.8.1 (via npm:^4.8.1) │ ├─ engine.io@npm:6.6.2 (via npm:~6.6.0) │ │ └─ ws@npm:8.17.1 [5e1ad] (via npm:~8.17.1 [5e1ad]) │ └─ socket.io-adapter@npm:2.5.5 (via npm:~2.5.2) │ └─ ws@npm:8.17.1 [5e1ad] (via npm:~8.17.1 [5e1ad]) │ └─ @ogfcommunity/variants-vue-client@workspace:packages/vue-client └─ socket.io-client@npm:4.8.1 (via npm:^4.8.1) └─ engine.io-client@npm:6.6.2 (via npm:~6.6.1) └─ ws@npm:8.17.1 [5e1ad] (via npm:~8.17.1 [5e1ad]) ```

document variant interface

Bugfixes

fix liberty check for fractional go (#342)

main ← fractional-index-capture-bug

opened 03:53AM - 24 Nov 24 UTC

JonKo314

+46 -22

Wrong intersection indices were compared. E.g. the surrounded corner stone in th…e test was not checked, because it was `changedIntersection[7]` and `AbstractBaduk`'s `this.intersection[7]` was already checked as a part of the long black chain. This fixes the [bug mentioned on OGS forums](https://forums.online-go.com/t/parallel-fractional-go-game-4/53434/100) of Game 4's round 16.

Solve move race condition, add games schema (#413)

main ← move_race_condition

opened 11:16AM - 04 May 25 UTC