hell no i’m not writing an e2e test for changing some window titles. The documentation for it is gibberish and it wasn’t even mentioned in the contribution guide. You don’t have to give me Meijin for this one. The whole point was to prove that this was easy to fix. In my project it would take 30 seconds. The only reason I took longer than a few minutes for this PR is because I was researching how to fix the problem from the root cause – to ensure all pages/routes in the future have a default page title and avoid the problem in my provided screenshot. I found the issue was with React Router v6 and I have no interest in spending more time to fix it.
I still have no appreciation for the frontend of OGS and never will. Look at the UI design I came up with for the Play page this week with zero graphic design experience ( UI update v0.3: Home page / play page rework ) that clearly works better than what any of your past designers came up with in 10 or 15? years. I’d rather make my own Go server than constantly submit PRs to this broken codebase. I know for a fact I can do a better job on the frontend – only the backend with setting up multiple versions of KataGo and serving APIs for user-hosted bots are things I would need to study.
BTW, one of the fixes the AI review requested could be automatically handled by an ESLint rule or plugin (merging import statements from the same package/module). That’s another example of extra work I wouldn’t have to do in my own codebase.