Gia
October 27, 2022, 1:17pm
1
I really think we need a thread for this, because nobody talks about them and I suddenly discover in my Profile that we now have a “Dropped games” category, filtering out casual rengos we’ve dropped.
Just
12 Likes
Say “thanks” to bhostetler18
online-go:devel ← bhostetler18:rengo-list-fix
opened 06:00PM - 11 Oct 22 UTC
This PR starts to fix #1998, which as @benjaminpjones noted is caused when a pla… yer resigns or times out from a rengo game. In these cases, the `rengo_teams` list does not contain the current player and this causes `GobanLineSummary` to think it is displaying in the style used on the https://online-go.com/observe-games page (the unwanted behavior where another player column is added).
All I have done is detect this scenario and display an empty cell across the three columns (opponent, clock, opponent clock) which cannot be determined. We could also stick some text in that empty space explaining that the game has been left, but it felt a bit cluttered when I tried this. I can think of a couple of ways to proceed:
1. Display the proper data in those columns. I believe this would need backend support, since there doesn't seem to be a way to obtain which team a player was originally part of after they leave a rengo match. I could be wrong, however.
2. Push these entries to the bottom of the games list, and potentially even have the option to hide them. I think I saw this requested somewhere on the OGS forums.
<img width="868" alt="rengo" src="https://user-images.githubusercontent.com/35665417/195164971-f5ac8636-e085-4010-8c0d-01cda19260e5.png">
10 Likes
Gia
October 27, 2022, 1:43pm
3
Shoutout to @bhostetler18 !!!
5 Likes
