Double click doesn't work on Android

VanquisherOfMisere · December 17, 2024, 6:45pm

Hi. I’d like to inform that double click to submit a move doesn’t work for me on Mozilla for Android. I set this in settings yet I have to submit every move by clicking a button. I’m afraid to play on a tablet without submitting, however I’m afraid I’m gonna to lose by time having to approve every move by clicking the button.

benjito · December 17, 2024, 8:04pm

seems like the goban’s double click is powered by the dblclick event, which is not supported on many phone browsers.

github.com

online-go/goban/blob/d928569931dc22216a3fc4d413c24c2a455ac7f6/src/Goban/SVGRenderer.ts#L570


      
                  ev.preventDefault();
              }
              return false;
          };
          const onFocus = (ev: FocusEvent) => {
              ev.preventDefault();
              return false;
          };
          
          div.addEventListener("click", onClick);
          div.addEventListener("dblclick", onDblClick);
          div.addEventListener("mousedown", onMouseDown);
          div.addEventListener("mouseup", onMouseUp);
          div.addEventListener("mousemove", onMouseMove);
          div.addEventListener("mouseout", onMouseOut);
          div.addEventListener("contextmenu", onContextMenu);
          div.addEventListener("focus", onFocus);
          this.on("destroy", () => {
              div.removeEventListener("click", onClick);
              div.removeEventListener("dblclick", onDblClick);
              div.removeEventListener("mousedown", onMouseDown);

Could probably be modified to just check “clicking staged stone”.

BHydden · December 17, 2024, 8:13pm

You could check whether it works on a chromium variant, such as chrome or brave

Feijoa · December 17, 2024, 8:37pm

I’ve checked before that it works fine (on Chrome, I think). The problem is you have to actually click, i.e. with a mouse. Unfortunately most people don’t use a mouse on their phone and double tapping does not have the same effect.

@VanquisherOfMisere were you using a mouse?

VanquisherOfMisere · December 17, 2024, 8:54pm

@Feijoa I didn’t use mouse. Does it work on Chrome without mouse?

Feijoa · December 17, 2024, 9:02pm

Pretty sure you need a mouse to generate a double click on Android Chrome. (I am testing with Brave.) You can try it here:

https://unixpapa.com/js/testmouse.html

Interestingly, on desktop, tapping can apparently generate a double click event. The problem on Android might have to do with how double tap does some kind of zooming thing instead of what we want.