Fix icon for each game type

flakeman2 · May 18, 2022, 9:11pm

There are different icons for tournament, ladder, and group games but currently the tournament icon is being used for all of them.

Please update the code to display the correct icon for the type of game that is being played.

Here’s an example game: Ladder Challenge: flakeman2(#308) vs timo_timo(#185)
This is a ladder game but the icon being displayed is a tournament icon.

Thanks!

shinuito · May 18, 2022, 10:03pm

Do you mean to use the ladder/group icon from the main menu?

GreenAsJade · May 18, 2022, 10:19pm

The use of that icon there does not mean “tournament” (as you know).

It means “this game is part of an organised thing, click here for details”.

I don’t think you can define it to be a dynamic icon in the way suggested, because Groups can have Ladders and Tournaments.

Is there a better icon that means “click here to see what organised event this is part of”?

benjito · May 18, 2022, 11:24pm

Actually I think there is no such thing as a “Group” game. The games that show up in groups are just all the games where both participants are members of the Group.

Therefore, it’s just a choice between linking a tournament and linking a ladder, which I actually agree we should use a different symbol for that since one exists.

Code

here is the line of code that needs to be changed:

{(tournament_id || null) && (
    <Link className="plain" to={`/tournament/${tournament_id}`}>
        <i className="fa fa-trophy" title={_("This is a tournament game")} />{" "}
        {_("Tournament")}
    </Link>
)}
{(ladder_id || null) && (
    <Link className="plain" to={`/ladder/${ladder_id}`}>
-        <i className="fa fa-trophy" title={_("This is a ladder game")} /> {_("Ladder")}
+        <i className="fa fa-list-ol" title={_("This is a ladder game")} /> {_("Ladder")}
    </Link>
)}

online-go.com/GameDock.tsx at 1feab25365f373570a7b06d4d66c62422492811a · online-go/online-go.com · GitHub

Just replace fa-trophy with fa-list-ol or some other icon I believe.