Having some trouble running the dev server

[benjito]

Hi all,

I really want to contribute, but I am having trouble getting set up with a dev environment I am on a Mac, but I am using the docker set up (docker-compose up) so I don’t think OS should be an issue. I’ve posted the errors that I see on the command line when trying to spin up the server. Any ideas? Let me know if I can post additional information.

 online-go    | ERROR in ./node_modules/react-charts/dist/react-charts.development.js
online-go    | Module not found: Error: Can't resolve 'performance-now' in '/usr/src/app/node_modules/react-charts/dist'
online-go    |  @ ./node_modules/react-charts/dist/react-charts.development.js 853:12-38
online-go    |  @ ./node_modules/react-charts/index.js
online-go    |  @ ./src/components/JosekiStatsModal/JosekiStatsModal.tsx
online-go    |  @ ./src/components/JosekiStatsModal/index.ts
online-go    |  @ ./src/components/JosekiAdmin/JosekiAdmin.tsx
online-go    |  @ ./src/components/JosekiAdmin/index.ts
online-go    |  @ ./src/views/Joseki/Joseki.tsx
online-go    |  @ ./src/views/Joseki/index.ts
online-go    |  @ ./src/routes.tsx
online-go    |  @ ./src/main.tsx
online-go    | [23:53:25] Starting 'reload'...
online-go    | [23:53:25] index.html reloaded.
online-go    | [23:53:25] Finished 'reload' after 1.63 ms
online-go    | Issues checking in progress...
online-go    | ERROR in src/components/JosekiAdmin/JosekiAdmin.tsx:328:75
online-go    | TS2339: Property 'includes' does not exist on type 'unknown[]'.
online-go    |     326 |                         selections.set(key, selections.has(key) ? !selections.get(key) : true);
online-go    |     327 |                         this.setState({
online-go    |   > 328 |                             any_selected: Array.from(selections.values()).includes(true),
online-go    |         |                                                                           ^^^^^^^^
online-go    |     329 |                             selections
online-go    |     330 |                         });
online-go    |     331 |                     }}
online-go    | 
online-go    | ERROR in src/components/JosekiAdmin/JosekiAdmin.tsx:340:75
online-go    | TS2339: Property 'includes' does not exist on type 'unknown[]'.
online-go    |     338 |                         });
online-go    |     339 |                         this.setState({
online-go    |   > 340 |                             any_selected: Array.from(selections.values()).includes(true),
online-go    |         |                                                                           ^^^^^^^^
online-go    |     341 |                             selections,
online-go    |     342 |                             all_selected
online-go    |     343 |                         });
online-go    | 
online-go    | ERROR in src/lib/rank_utils.ts:19:27
online-go    | TS2307: Cannot find module 'readline' or its corresponding type declarations.
online-go    |     17 | 
online-go    |     18 | import {_, interpolate, pgettext} from "translate";
online-go    |   > 19 | import { Interface } from "readline";
online-go    |        |                           ^^^^^^^^^^
online-go    |     20 | 
online-go    |     21 | export interface IRankInfo {
online-go    |     22 |     rank: number;
online-go    | 
online-go    | ERROR in src/views/Game/AIReviewChart.tsx:261:43
online-go    | TS2339: Property 'includes' does not exist on type 'number[]'.
online-go    |     259 |         let use_score_safe = this.props.use_score
online-go    |     260 |           && this.props.ai_review.scores != null
online-go    |   > 261 |           && !this.props.ai_review.scores.includes(0);
online-go    |         |                                           ^^^^^^^^
online-go    |     262 | 
online-go    |     263 |         if (this.props.entries.length > 0) {
online-go    |     264 |             entries = this.props.entries.map((x, i) => {
online-go    | 
online-go    | ERROR in src/views/Joseki/Joseki.tsx:1438:12
online-go    | TS2339: Property 'finally' does not exist on type 'Promise<void>'.
online-go    |     1436 |             console.log("Audits GET failed:", r);
online-go    |     1437 |         // tslint:disable-next-line:no-floating-promises
online-go    |   > 1438 |         }).finally(() => {
online-go    |          |            ^^^^^^^
online-go    |     1439 |             this.setState({extra_throb: false});
online-go    |     1440 |         });
online-go    |     1441 | 
online-go    |

[benjito]

I should add: when I go to localhost:8080 or http://dev.beta.online-go.com:8080/, I get an empty page. There is some source downloaded, but nothing visible in the UI. Here are some of the errors I am getting by opening the browser developer tools:

[benjito]

Okay, I wasn’t able to figure out docker, but just running make worked just fine! Await my pull requests!

[BHydden]

yeah docker was always broken… I thought @anoek took it out already??? if not he probably should

[benjito]

Okay, appreciate you letting me know. If this is actually the case, it’s worth noting that CONTRIBUTING.md states this is the “easy” way:

Getting setup is even easier with Docker Compose, you’ll need to have Docker installed, then within the working directory run the following:

# Run this to start the development server and build system
docker-compose up

[BHydden]

yep, if this is actually the case, I have already submitted a PR requesting it be removed. We’ll see if I remembered correctly or not lol

[benjito]

Awesome- thanks BHydden!