Minor updates to the Undo functionality

Hello OGS!

A couple of minor changes to undos:

  1. You can now request an undo if your opponent has already made a move, this will undo the past 2 moves. When requested, you’ll see both moves marked

  2. You can now cancel an undo request (the button shows up to replace the ‘undo’ button itself)

  3. I changed the symbol drawn on the stones from a ‘?’ to a ‘↶’ to be more international friendly

32 Likes

Hallelujah!

8 Likes

Why is ‘?’ not international friendly?

2 Likes

Mainly thinking of languages that don’t use the ?

Secondarily though, it occurred to me that the ? is used in chess to indicate a bad move, so combine those two things together I thought a different symbol might be a good idea.

10 Likes

;;;;;;;;;;;;;;; :sweat_smile:

7 Likes

Allow undo request on your move for context. And that was only the most recent time I asked for this, I seem to recall also making a post on some prior system before discord.

1 Like

Currently, the REST gameData subobject from api/v1/games/X still only includes on the original “undo_requested” int value, and not the new undo_requested_by and undo_requested_move_count values which can be found on the socket gameData object. Is there a plan to include those in the REST object as well?

5 Likes

Whoops sorry about that. I’ve pushed out an update to the beta servers that have those fields in there for you, I’ll update production either later tonight or early tomorrow morning.

6 Likes

Awesome! These are all very good changes.

1 Like

Nice design. I’m curious about how multiple undos are managed (if any)?

1 Like

You know, some languages read right to left. :wink::winking_face_with_tongue:

So this arrow would be pointing “forward”.

(I’m sure they’ll figure it out. A symbol that is going somewhere is surely better than one that represents confusion)

4 Likes

Currently the interface only supports undoing the last move or 2 moves still, although the backend supports undoing more so if we figure out a nice ui to doing more than 2 and people want it we could roll back to any state in the game theoretically.

1 Like

It’s true, and we should flip them for rtl languages.. might have to do that at some point here :sweat_smile:

4 Likes

I think ↶ is fine, it represents a U-turn.

3 Likes

Thank you for all the work, anoek.

2 Likes

Great! :slight_smile:

turns out this design causing some people to timeout:
https://forums.online-go.com/t/unable-to-make-a-move-after-opponent-requested-undo-beat-the-kyu-be-a-dan-tournament/59369/21


(it’s harder to understand which color to move)

3 Likes

Thanks for figuring that out @square.defender !

@anoek this might be one for you I think, since it’s a UI design consideration.

TIL that a Greek question mark looks exactly like

an English semicolon (;)

PLUS, TIL about yet another Discourse formatting tag

1 Like

Maybe join both marks (the arrows and the last move circle. It’s bit less “esthetic” but more clear (no loss of the usual information).

Besides that, write clearly who paused the game:

Game paused by white.

Not just

Game paused.

Don’t confuse the player requested to accept undo by asking to guess who’s turn it is (even if he could guess)