New feature or did I miss it earlier?

Gia · June 3, 2024, 4:07pm

Now my browser notifications say “it’s your turn against opponent”.

Did it say “it’s your turn in game 100000000000000” before? Or I misremember?

Nice. Open to improvements, but nice

benjito · June 3, 2024, 4:16pm

Yes, nice new feature, and a new contributor as well!

github.com/online-go/online-go.com

Include opponent's name in turn notification

online-go:devel ← LForchini:improve-notification-text

opened 08:49AM - 03 Jun 24 UTC

LForchini

+11 -4

Fixes # ## Proposed Changes - Change the format of the notification when… it's your move in correspondence games to remove the game id and instead include the username of the opponent. ## Motivation I feel that the game id does not have any use in the notification, whereas I think the opponents name would be more useful. I am new to this codebase so any advice would be useful, specifically if there's an established method for finding the name of the opponent. ![Screenshot from 2024-06-03 09-47-38](https://github.com/online-go/online-go.com/assets/31443269/f771f398-a6fe-45ac-bd09-6f70468369ef)