Score seems weird, did I miss a border?

shinuito · January 12, 2023, 10:30am

online-go/goban/blob/b1313e44a143e5903f58699614d231ada6800d71/src/ScoreEstimator.ts#L363-L373


      
          public estimateScore(trials: number, tolerance: number): Promise<void> {
              if (!this.prefer_remote || this.height > 19 || this.width > 19) {
                  return this.estimateScoreWASM(trials, tolerance);
              }
          
              if (remote_scorer) {
                  return this.estimateScoreRemote(tolerance);
              } else {
                  return this.estimateScoreWASM(trials, tolerance);
              }
          }

There’s this sort of a check in score estimator code, between a compiled score estimator locally and a remote call by the looks of it, but I don’t understand the details. You can see there’s a check for sizes bigger than 19 though.

github.com

online-go/goban/blob/b1313e44a143e5903f58699614d231ada6800d71/src/ScoreEstimator.ts#L30-L44


      
          /* This script is used on both the front end and back end, and the way the
           * OGSScoreEstimator module is loaded is quite differente between the two.
           *
           * On the server, the OGSScoreEsimtator module is loaded by score-estimator.ts
           * and the set_OGSScoreEstimator function is called with the module.
           *
           * On the client, the OGSScoreEstimator script is loaded in an async fashion,
           * so at some point that global variable becomes not null and can be used.
           */
          
          /* In addition to the OGSScoreEstimator method, which is a wasm compiled
           * C program that does simple random playouts, we have a RemoteScoring system
           * which needs to be initialized by either the client or the server if we want
           * remote scoring enabled.
           */

In the estimate score remote function there’s a comment saying

github.com

online-go/goban/blob/b1313e44a143e5903f58699614d231ada6800d71/src/ScoreEstimator.ts#L415


      
                      for (let y = 0; y < this.height; ++y) {
                          for (let x = 0; x < this.width; ++x) {
                              score_estimate += res.ownership[y][x] > 0 ? 1 : -1;
                          }
                      }
          
                      if (!res.score) {
                          res.score = 0;
                      }
          
                      res.score += 7.5 - komi; // we always ask katago to use 7.5 komi, so correct if necessary
                      res.score += captures_delta;
                      res.score -= this.engine.getHandicapPointAdjustmentForWhite();
          
                      this.updateEstimate(score_estimate, res.ownership, res.score);
                      resolve();
                  })
                  .catch((err: any) => {
                      reject(err);
                  });
          });

so it makes me think that the remote one is probably katago+ unless there’s some fall back method, and the local one is random playouts and flood fill and things.

I guess we also have

I probably misremembered then about other non standard board sizes.