Search box in game history

Feedback Bug report
1

Search box in game history doesn’t work on my android smartphone, either on Samsung browser and Chrome.

I can write a name but then nothing happens.
Pressing enter on my keyboard doesn’t work.
Sometimes randomly a dropdown menu opens up with possible choices of players with matching names but I can’t have it on purpose and when I tap on it it does nothing.

Screenshot_20211222-080708_Chrome
Screenshot_20211222-080708_Chrome1080×959 112 KB

4 Likes
2

Can confirm it is broken for me too… it definitely used to work on my phone.

@benjito @shinuito @GreenAsJade any of you guys poking around in game history recently?

Edit: broken on my desktop too.

2 Likes
3

Better tag @anoek too I think I heard he was going to poke around with optimising game history somewhere.

4

Yeah I’m seeing

Uncaught TypeError: Cannot convert undefined or null to object
    at Object.Gu.updateGameSearch [as onComplete] (User.tsx:605)

and or

Uncaught TypeError: Cannot set property 'alt_player' of undefined
    at Object.Gu.updateGameSearch [as onComplete] (User.tsx:603)
1 Like
6

I like the next line:

at ko.complete (PlayerAutocomplete.tsx:81)

Wait, what has this got to do with a ko? :smiley:

(The issue has been isolated to “what was the change that caused it”, so I’m guessing a fix won’t be too far away).

3 Likes
7

@benjito was playing around with types recently…? Could be related?

8

EDIT: not my types work (which should be a no-op), but I think I did break this. When I updated the Tournaments page, I updated the way filter works in PaginatedTable slightly.

3 Likes
9

Should be fixed now :slight_smile:

6 Likes
10

Great work team :heart:
Can confirm search is working again on my end.

3 Likes