I’d like there to be a keyboard shortcut that has the same functionality as the ‘fast-forward’ button for variation navigation (ten moves at a time). I feel the best candidate would be Shift + [Arrow Key].
I often review games on the computer and it can get tedious to tap an arrow key many times. I often catch myself trying Shift + Arrow, and I’m surprised it doesn’t work.
Just because you knew what you were talking about doesn’t mean everyone else does. Pictures go a long way to adding clarity, especially in a multilingual community. There is no need to be rude when others are trying to be helpful.
@MystWalker why not? The danger in adding lots of redundant shortcuts is that an app or site specific one will overlap with a generic system one or interfere with it. This is more so on the Mac than other platforms, because on the Mac there seems to be no rhyme or reason to the system shortcuts – i.e. there is no convention like “Shift + navigation keys are reserved to apps and sites and safe to use by them”, while I know some such conventions apply on other platforms.
Of course this is not a good reason to have no shortcuts at all. Just an argument for balance & moderation.
Okay, that’s some good feedback @genbeart. Is there a way we can check what kind risk is being run by adding Shift + Arrow? Maybe a different modification key would be better, like ctrl? (probably not Alt or ⌘)
I think there’s utility in having similar functions having similar hotkeys. I like the idea of Multi-step being a modification of single step.
All that said, I don’t know how difficult a change like this would be. What would be involved in making something like this a reality?
I think @genbeart was just discussing the downside of having multiple keyboard shortcuts, not implying that Shift+arrow was specifically bad. I agree Shift+arrow is easier to remember than Page Up, Page Down and less likely to collide with system functions. In fact, page up/down should scroll the page, but doesn’t because OGS analysis is currently swallowing this up!
I think fairly simple. You can take a look at the relevant code here:
I’m not sure if "shift-right" and "shift-left" work as shortcuts, but if they do, it would be a 2-line code change.
Edit: reading the code in KBShortcut, it seems like "shift-right" and "shift-left" will work as expected. If you’re interested in putting together a pull request, I recommend checking out CONTRIBUTING.md. I’m also happy to answer any questions!
Thank you very much for the information, @benjito!
I wouldn’t mind learning how to contribute to the OGS project. It’s not something I can commit to any time soon, but I’d like to try some day. I think this would be a good thing to start with when I can.
I’d like to reach out to you when that time comes!
Lastly, is there some kind of approval process for making a change like this? Does it happen after making a pull or before? I wouldn’t want to step on toes!
I’m not sure if it’s necessarily a good idea to change these keybindings. There are pros and cons to either way:
Shift + Left / Right is helpful for those that might not have Page Up / Page Down on their keyboards.
Page Up / Page Down might be better for accessibility in avoiding the need for pressing two keys at the same time.
In addition, there will certainly be many people (on both sides) that naturally prefer and/or find either way more intuitive.
However, if we change an existing keybinding, I suspect the most likely thing will be that many people that are used to the existing one will come to complain that Page Up and Page Down no longer work (possibly being unaware of the change).