Most of that stuff has fixes now, thanks.
online-go:devel ← GreenAsJade:fix-plot-by-games-on-phone
opened 03:41AM - 15 Aug 21 UTC
Fixes:
- Lingering PieChart artifacts on resize (corner cases)
- Display of … game hover popup when pie chart won't fit (don't do that)
- Overlapping textual win-loss information in by-game chart in phone form factor (don't display this info, for now)
- Display of meaningless points when game is finished (don't do that)
- Display result of game that is finished in the title (do do that)
## Proposed Changes
Got rid of renderWinLostResultsAsText in the by-game component, for now. This is actually buggy in the original chart component: the render of this extends below the extent of the element (it looks like vertical clip was turned off to allow this). but due to fortunate spacing in the rating-by-time case, it looks almost OK.
I couldn't quickly work out how to solve this properly - the whole "calculation of the height of various elements" needs a big tidyup to be comprehendable, then this fix would probably be easy. In the mean time, simply not showing it works.
The turning off and on of pie chart had some buggy cases during resize even in the original - that should be fixed now (I had thought that pushing it off to the right offscreen was enough, but it turns out sometimes it can sneak onscreen in thin form factors, so now it is completely un-rendered)
shinuito:
On mobile the pop up game feature is a bit iffy. It disappears after about a second and sometimes it’s easy to click into the game by accident.
I’m not sure where to put it, unless one wants to leave collapsible space between the rank graph and current games.
It occurs to me that clicking on the rating chart in the phone form factor should just take you direct to that game page. There’s not much point in popping something up the fills the page anyhow…
5 Likes