Add Game-Level curve besides Time-Level graph!

I’ve submitted a PR for anoek’s review.

Overview:

7 Likes

Great tutorial video :heart_eyes::heart_eyes::heart_eyes::heart_eyes::heart_eyes:

1 Like

Where is the video? On Youtube? I can’t see youtube because I am in China Mainland right now.

It’s hosted on github actually. But this feature is available on beta.online-go.com now, so you can check it out :slight_smile:

3 Likes

Can I suggest that the info that’s displayed on the side, about the game and such, also displays the game result? It’s not really clear whether the game is a win or a loss for the player right now without clicking on the game.

5 Likes

Just to try and be helpful

On mobile the pop up game feature is a bit iffy. It disappears after about a second and sometimes it’s easy to click into the game by accident.

I’m not sure where to put it, unless one wants to leave collapsible space between the rank graph and current games.

3 Likes

Hmmm - I tried this form-factor on my laptop and didn’t get that… this is why we have beta :smiley: :smiley:

Thanks for finding this… definitely need to clean that up.

The intent was that if you don’t have the pie chart (because the form factor is too narrow) then you don’t get the game preview either (which is what it does fo rme)

1 Like

Well, if the line sloped down to this point it was a loss, and if the line sloped up it was a win :smiley:

But I agree it could be handy to show that…

Well, we’ve had enough evidence in the past that this is not always the case (although that’s hopefully fixed), and with humble rank, it’s demonstrably not always the case in the first couple of games.

1 Like

Another question I have, which I guess you can see in the last screenshot is: What are the numbers on the side of the board showing?

image

When a game is scored, it’s not the score anyway. I think it’s something like captures and Komi together? It’s not very useful. I guess hide it or swap it for the result like Vsotvep says, or ideally the score if it is there.

2 Likes

Yeah - the mini-goban has never been used for finished games before (as far as I know?) … I bumped into a few problems like these, obviously didn’t catch everything. I was so happy to have the image of the game I wasn’t really looking at the numbers :smiley:

5 Likes

Most of that stuff has fixes now, thanks.

It occurs to me that clicking on the rating chart in the phone form factor should just take you direct to that game page. There’s not much point in popping something up the fills the page anyhow…

5 Likes

The fixes and enhancements are available now,

As always, feedback welcome.

6 Likes

bugs:

when window is narrow enough that circle diagram disappears:

because (1) is always stays too far at the right of the window, width of site always more wide than window and it causes (2) to always exist

I tried to see rank of highest point on the graph, but its impossible (3). Game preview appears in front. It should be disabled for narrow window or moved to other side of what I click on the graph.

It is supposed to be the case that the preview will never appear if the pie char it not there, and thus will never appear over the graph.

Can you let me know what screen size that shot comes from?

I’ve reproduced this now … will fix.

Thanks.

1 Like

Actually, I didn’t quite reproduce it. I can reproduce the preview appearing over the graph, which is not intended, and I can easily fix that.

However, I can’t reproduce your (1). You have a scroll bar there which is obscuring the window - I don’t get that. I can’t force my browser to produce a vertical scroll bar on the profile page no matter what I do!

So … what browser, device and screen resolution?

Thanks!

1 Like

in both Chrome and Opera. Resolution of window you can see in screenshot, it works with any more narrow sizes of window too.
Just move that button slightly to the left, you don’t need to have that bug yourself to fix it.

What device is this on? As I said, I don’t get scrollbars on this page at all.

Do you get the popup from clicking, or only from hovering?

If you click outside the graph and wait a moment, the preview will disappear. Then you can chose the maximum point that you want. This is a workaround, not a fix - I’ll fix it.

Thanks for the advice. I’d rather know what’s causing the problem.

Windows, …not the latest version
I don’t see how sceen size may have anything to do with window size

from hovering, I can’t even place red dot in intended coordinate.

you mean horizontal?

I mean the scroll bar that is on the right side of the window, the vertical scroll bar that is obscuring the button.

But I don’t get either of those scroll bars - vertical or horizontal.

You’re right - I was asking of course about window size - I usually have OGS full-screen, so I used the wrong word because they are both the same for me usually.

If you got that preview by hovering, then it should disappear easily when you move your mouse away from it (off the graph). That will allow you to chose the point that you want.

Things are more difficult on a mobile device, where it is click instead of hover. Then I can’t detect when you mouse away (because you aren’t mousing :slight_smile: ).

Your case has shown that I need a solution for this (which is probably "don’t show the preview when the pie is not showing)

Just move your mouse out of the graph, the preview disappears, move it back in to the coordinate that you want.

1 Like