Audio updates v2

I hadn’t thought of this, and at first thought “weird idea”, but actually I too have forgotten to press submit, and I can see how this would help. Clicking on the board is not placing a stone, for submit move button mode!

2 Likes

I rarely play on my pc with the sound on but you’ve made me realise that when I do this happens to me every time and you’ve nailed the solution with this!

1 Like

@Tokumoto @Eugene @teapoweredrobot @anoek

proposal: for double click and submit botton modes, the first click places an X on the intersection with no sound… and confirmation places the stone with the sound… thoughts?

2 Likes

X or an empty circle with a + in it, would be better, if it’s not too much of a trouble.

6 Likes

This would be great.

2 Likes

I like the new sounds very much!

3 Likes

Fixed

Agreed, I wen’t back and forth on this, but yeah I just updated them to make more sense and it’s better.

Interesting, I’ll try and fix these.

These are great suggestions, I’ll implement both.

8 Likes

Also I added a short vibrate effect on mobile devices when a stone is placed, let me know what y’all think. You can turn it off in settings of course.

6 Likes

If a setting is annoying, it’s easy enough to go turn it off… but if a setting is off by default, nobody is going to go look for it… there are many features on our site that a lot of people don’t know exist simply because they’re not on by default.

Reminds me of the attitude of websites that used to auto-play music when you open them up. :rage:

If you can’t imagine how else to make a user aware of a feature… :cry:

Awesome job! It’s customization like this that is going to put OGS above the rest I feel. :smile:

7 Likes

Yeah the counting up I felt wasn’t “right” yet, or at least quite horrible… but it was an odd concept for me anyways so I wasn’t sure what the expectation actually was I suppose. Yours sounds better.

2 Likes

It should be like this shouldn’t it?
https://www.britgo.org/bgj/10643

“30 seconds, no time left;
40 seconds, no time left;
50 seconds;
1, 2, 3, 4, 5, 6, 7, 8, 9.”

1 Like

Yep, I think that’s pretty much what @S_Alexander described. I don’t think I want to deal with the followup “no time left” / “6 minutes left” (or “6 periods left”) unless it turns out folks really want that, but I think that’d be a bit too much chatter for an online game. The way it counts up though, I’ll make it match.

3 Likes

If i make it count up starting from 60 seconds but use byo-yomis over 1 minute, the countdown goes down instead up.

If i try to use old amy voice for counting to 60, it hops to claire after “ten.” Guess there isnt amyvoices from 11 onward?

2 Likes

Ties are still “black wins by 0 points,” and its been like that for years now :<

3 Likes

Now the sound effect for placing a stone is played even when the volume is set to 0 on the right panel.

3 Likes

I’ve just played with the sound for the first time on my desktop and they are incredibly nice! It’s such an improvement I just had to pop over to the forums to clog them up a bit with my disproportionate gratitude!

6 Likes

With the updated code? I added code so it specifically should no longer play when the volume is 0 :frowning: Anything interesting in the console by chance?

2 Likes

I just tried testing this out on beta server and I think it broke double click to move… For me they both function as submit move button. (single click works correctly)

Again, it only happens when the volume is set to 0 when the page is loaded:

WASM support detected, score estimator will be fast 22217936:1:136
Loading failed for the <script> with source “https://www.googletagmanager.com/gtag/js?id=UA-37743954-2”. 22217936:1:1
Playing sound bite:  silence  at volume:  0.8 4 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Successfully played silence from  stones ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38708
Successfully played silence from  game_voice ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38708
Successfully played silence from  countdown ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38708
Successfully played silence from  effects ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38708
Playing sound bite:  white-2  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  black-2  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  white-2  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  black-5  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
audio-capture-stones Object { count: 1, already_captured: 3 } goban.min.js:16:48291
Playing sound bite:  white-4  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  black-4  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
audio-capture-stones Object { count: 2, already_captured: 4 } goban.min.js:16:48291
Playing sound bite:  white-4  at volume:  0.6400000000000001 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
audio-capture-stones Object { count: 1, already_captured: 4 }

when I set a volume (by clicking on the volume icon)

Audio group  stones  unlocked successfully, sounds should now work ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38577
Audio group  countdown  unlocked successfully, sounds should now work ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38577
Audio group  game_voice  unlocked successfully, sounds should now work ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38577
Audio group  effects  unlocked successfully, sounds should now work ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:38577
Playing sound bite:  white-4  at volume:  0.4 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  black-5  at volume:  0.4 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  white-2  at volume:  0.4 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
Playing sound bite:  black-4  at volume:  0.4 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36622
audio-capture-stones Object { count: 1, already_captured: 6 } goban.min.js:16:48291

and changing it back to 0 (by clicking on the volume icon)

*NOT* Playing sound bite:  white-5 , volume was  0 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36804
*NOT* Playing sound bite:  white-1 , volume was  0 ogs.5.1-2130-gc8faf30-8b06dc7a1b74b5afd7b4398e664a3dbc.js:17:36804
3 Likes