Black or Blanc

Conrad_Melville · December 28, 2021, 12:09pm

For the benefit of our non-native English speakers, “irregardless” is a substandard usage that began life more than a century ago as a satirical joke by some Ivy League students. It got such a drubbing in the press about 30 or 40 years ago, that I have rarely seen it since. The standard word is “regardless.”

Groin · December 28, 2021, 12:16pm

Good checking which i confirm (and which creates even more confusion!)

I think it would be well considering to change it for italian and Spanish if needed too (maybe more languages?)

shinuito · December 28, 2021, 12:25pm

I think that’s probably the case

github.com

online-go/online-go.com/blob/aae041ec7cde0ff6c1d82b4d4ae9dab1e7983ee7/src/views/Game/AIReview.tsx#L1086


      
                  </div>
              );
          },
          SingleValue: ({data}) => (
              <React.Fragment>
                  <ReviewStrengthIcon review={data} />
                  {(win_rate >= 0 && win_rate <= 1.0)
                      ? (this.state.use_score && this.ai_review.scores
                          ? <div className="progress">
                              {(score > 0
                                ? <div className="progress-bar black-background" style={{width: "100%"}}>B+{score.toFixed(1)}</div>
                                : <div className="progress-bar white-background" style={{width: "100%"}}>W+{(-score).toFixed(1)}</div>
                              )}
                          </div>
                          : <div className="progress">
                              <div className="progress-bar black-background" style={{width: win_rate_p + "%"}}>{win_rate_p.toFixed(1)}%</div>
                              <div className="progress-bar white-background" style={{width: (100.0 - win_rate_p) + "%"}}>{(100 - win_rate_p).toFixed(1)}%</div>
                          </div>)
                      : <div className="pending">
                          <i className='fa fa-desktop slowstrobe'></i>
                          {_("Processing")}

BHydden · December 28, 2021, 12:48pm

Think you’re lost

benjito · December 28, 2021, 4:21pm

Some more language nerdery…

TFW you realize “Black” and “Blanc/Bianca/Blanco/Bleach/Blanche etc…” come from the same linguistic root

Edit: so basically B+5.5 is “working as intended”… right?

Edit 2: Edit 1 is a joke! Someone should submit a translation patch!

Groin · December 28, 2021, 4:32pm

No.
Not in a french translation where it should be N +5.5 (when assessment made by the AI)

See this screenshot

Edit: ok i see, an ethymologic joke

benjito · December 28, 2021, 6:53pm

@Groin, I felt bad for the unclear joke. Submitted a PR to make up for it

Once that’s merged, you should be able to add the proper translations at translate.online-go.com!

Groin · December 28, 2021, 6:59pm

All fine .

shinuito · December 29, 2021, 10:24am

I’m glad you did it because I still don’t really understand the pgettext and interpolate that you used :). I’m still not really sure how the underscore works too in typescript I guess you can name variables with an underscore, but otherwise not sure.

I’ll have to google it.

anoek · December 29, 2021, 12:10pm

The underscore is indeed just a function created in translate.ts, nothing special - it’s a traditional translation function name for readability I suppose. pgettext includes a leading string that’s used for context for translators, but isn’t displayed to users. interpolate is just a string formatter, specifically replace the {{blah}} with the blah parameter.

And on topic, FTR the strings are up ready to be translated

jlt · December 29, 2021, 12:25pm

I’ve submitted the French translation “B+” → “N+” and “W+” → “B+”.

Groin · December 29, 2021, 2:39pm

I am so happy that this issue is going to be solved quickly. Thanks to all of you.