Feature Request: BadukTV Theme for OGS

OGS Development
1

My favorite Go board/stone theme yet is the BadukTV theme. I really appreciate that WeiqiHub has implemented that theme as well.

I would love for this theme to be added to OGS. This is an example Sabaki implementation from upsided:

Anyways, I’d love for this to be added to the standard options for OGS themes.

EDIT: Ok, this can somewhat be achieved with the customization feature in the settings:

The board works fine doing this. The stones seem to appear to small. Also I guess the shadow effect for the stones should be set to “none” because the stones already come with one.

8 Likes
3

@Fragile_Pākehā why did you delete your reply? That was actually interesting information.

1 Like
4

Once I started changing things, it led to an endless sequence of changes and half-formed thoughts. That’s okay, I have a plan…

hs bushes
hs bushes372×324 17.7 KB

5

Haha, now I’m curious.

@GreenAsJade @noob42 @benjito This is actually something I’d want so much that I’d do the PR myself. But there currently are 12 different board themes and 6 different stone themes for each color. I think for this to look good I’d have to replace one of the existing board and stone themes.
What do you guys think? I guess it’s always hard to remove something that already exists since someone might be using that theme currently.

6

Maybe also take a look here:

Also includes the baduktv theme

2 Likes
7

Hello fellow BadukTV enjoyer :3
I was the one that added it to WeiqiHub and Godeon already shared my OGS version.
I also did it for Katrain if you use katrain grab it here GitHub - SoumyaK4/Katrain-Theme-SoumyaK4: Katrain Theme: BadukTV+JeffSounds · GitHub
I also did a better version of BadukTV theme on my WeiqiHub fork but playing isn’t the main focus of that

2 Likes
8

Hey :smiley:

Thank you very much man!

Why did you decide to do this via Tampermonkey instead of either A. Using the customization feature of OGS or B. Creating a PR for OGS?

9

The other alternative to removing one would be to add two more (instead of one), so that it’s an extra column in “more options”.

It’d have to be possible to have variable shadows.

A bigger challenge is that the screenshots they show have random stone placement.

I remember trying to get something like that working, and finding it was too hard…

2 Likes
10

The BadukTV part isn’t via tampermokey, its using the OGS customisation. tampermonkey is because of the scrip, I did it because I have a small screen and I wanted to change the look and feel a bit.

1 Like
11

That would be one alternative. Is it an alternative that we want? Would be good to decide that first.

So you’re saying the stones shouldn’t have a default shadow, right?

Yes, that is out of scope for this thread. I think that’s a whole different topic.

So I’ve looked at your repo now. It’s basically what I already had because it’s also using the files upsided created.

The board looks really good out of the box but I think the stone size needs adjustment:

I actually think Fragile_Pakeha was going in a good direction with the stone resizing.

12

What I was clumisily saying is that I think the shadow is fixed in there in the code right now but it’d be easy enough to parameterize (by whether the stones want it or not).

Certainly “easy” in comparison to randomizing placement :slight_smile:

There are two decision points:

  1. Community.

If you mock it up and share it we’ll hear whether people like it.

  1. anoek . Dev chat is good for that but you could also raise a PR with your mockup and he’ll see it.
1 Like
13

Hi @Regenwasser
Need any help getting started with setting up the OGS Repo, feel free to personally ping me here (or DM me), or meet us in the dev (Slack) chat.

Do check the CONTRIBUTION guidlines.

3 Likes
14

Off topic and out of scope for this discussion, but I wanted this quite badly too and took a stab at it. PR is up here. Hard to do it the same way as Sabaki, not nearly as hard to just offset each stone by some number.

7 Likes
15

This is what I love to see from the community.

Wether this PR gets merged or not, thank you for putting it in.

1 Like
16

I also created a GitHub Issue with two linked PRs for the original idea I proposed.

I created a BadukTV board theme and BadukTV stone themes. I think it turned out pretty good. It’s working with shadows and now the size fits as well.

image
image1262×1292 235 KB

I did end up adding a seventh theme column though:

image (1)
image (1)370×485 46.2 KB

5 Likes
17

Wow, my PR actually got merged! Amazing! Thanks so much to OGS for allowing user contributions.

I do feel responsible for this change, since I made it, if anyone here has any suggestions, feedback or complaints towards this new change then please write it here. I have no issue fine tuning or enhancing this.

Also thanks to @GreenAsJade for the continuous encouragement to contribute and thanks to @benjito for the help with coding. This change wouldn’t have happened without any of you. And of course thanks to the boss man for merging this! :smiley:

Last but not least thanks to @Feijoa for the Community theme. I encourage everyone to upload cool new themes here Board backgrounds library

Make also sure to leave a like for the themes you think are great. Might be useful some day.

11 Likes
18

Whoa, what a nice surprise to see my pic make it up there!

IANAD, but does anyone else think it would look better with a touch of red (like iron oxide) in the lines?

For example with #370d0d, compared to the current one:

image
image260×259 32.2 KB
image
image259×258 32 KB

3 Likes
19

When I created the PR Claude (the AI) actually commented on this. Claude said that he determined that the other boards have quite a different color composition compared to this new board. He then went on to ask if I was sure that I want to use the same line colors even though the board colors differ.
It’s totally crazy how far we’ve gotten with technology and AI. I was pretty amazed when I read that.

Anyways, I think you’re right the line color fits better with the theme. Then again that also leads to the lines being less visible on the board. So I’m not totally certain that this would be a good change.

1 Like