Rematch settings treat rematcher as original challenger

smurph · February 12, 2022, 4:16pm

Say 5d challenges 8k and uses “Your color: White”.
If 8k uses the rematch button afterwards, 8k will play white by default.

It’s a minor thing, but probably unintended so might warrant a fix.

Groin · February 12, 2022, 4:27pm

It could have been intended but in the view of even games only…

benjito · February 12, 2022, 6:43pm

github.com/online-go/online-go.com

Rematch: challenger_color is incorrectly set in the challenge modal

opened 06:40PM - 12 Feb 22 UTC

benjaminpjones

good first issue

**Describe the bug** Request a rematch on a finished **To Reproduce** Steps… to reproduce the behavior: 1. Go to a finished game. 2. Request a rematch. 3. Notice that **Your Color** is set to the opposite color from that which you played. **Expected behavior** **Your Color** to be set to what it was during the game. **Additional context** Original bug report from smurph: https://forums.online-go.com/t/rematch-settings-treat-rematcher-as-original-challenger/41466 ----- ## Good first Issue There is a type mismatch between `props.config.challenge` and `state.challenge`: Props looks like this: ``` { "game": { ... "time_control": "fischer", "challenger_color": "white", // <----- inside challenge.game "rules": "japanese", ... } } ``` But state.challenge looks like this: ``` { ... "challenger_color": "random", // <----- outside challenge.game "game": { ... } } ``` The following code can be modified to add `challenger_color` in the right place: https://github.com/online-go/online-go.com/blob/e5d1d827aa7ee57184ad3c13365fa51dcd37af21/src/components/ChallengeModal/ChallengeModal.tsx#L215-L227

Looks like a one-line fix. Since severity is low and it’s an old bug, I marked this as a “good first issue”

antonTobi · February 12, 2022, 9:19pm

I think for even games with random colors, switching colors in a rematch would be expected behavior. (this way you could easily play a best-of-5 with alternating colors, for instance)

So perhaps if last game was “Your color: random” then next game could be automatically set to the color you didn’t get that game?

(when color is explicitly set I agree that it should stay the same on rematch)

benjito · February 12, 2022, 9:46pm

I agree that would be ideal @antonTobi (or actually I would prefer more “Random” over alternating colors). Could probably work similarly for Auto (although the likelyhood of switching is much smaller).

However, we’re no longer talking a “one-line fix” since the original challenge parameters are not available once the game has actually started. All we know is who played which color. Something in the API would need to change.