Some bugs report

Hi! I have decided to report some small bugs :slight_smile:

  1. When I play my correspondence games, very often the “go back” browser button doesn’t work properly. It’s impossible to reach my very previous game. It would help to accept the score in some games because reaching them from my home/profile is not always easy.

  2. Often, during my games, I see the wrong players. The game chat remains unchanged. I have 2 screenshots, but I can take more if needed.

Screenshots

From a game against :sparkling_heart: KoBa :sparkling_heart:

Game link I am black here

  1. If you have 10 open correspondence games and you try to open a live game, the error you get is " You already have 10 outstanding open correspondence challenges". I think they should be unrelated (or, at least, the text should be changed).

  2. The notifications about time left don’t show the correct time, and I do not receive a notification for each game with little time

I’m using Mozilla Firefox 95.0 . I didn’t try other browsers.
None of these is serious, but you may not have been aware of them.

I add also a suggestion: games should cycle according to the remaning time and not according to the game id. Or rather, players should be able to choose the order.
Imagine that your homepage/profile does not load and that getting near to 0 moves to play is very hard for you. Avoiding to lose by timeout could become complicated.

Thanks :slight_smile:

14 Likes

Also, aren’t the singular and plural of the Italian for capture (cattura, catture) the wrong way round?

2 Likes

Yes, “cattura” is singular and “catture” is plural. I had not noticed that they are reversed :sweat_smile:
It’s not about the wrong players: it’s wrong in every game.
It’s another (minor) thing that should be changed.

1 Like

I went ahead and changed the entry for “capture” at Online-Go.com | Italian | Online-Go.com Translation Server. Could be a few days before it takes effect.

I think the problem was that the interfaces says “Plural form 0” and “Plural form 1” instead of “singular” and “plural” so the translator probably thought 0 catture, 1 cattura…

2 Likes

2 more things:

In this double elimination tournament döskee has been eliminated after only one defeat. The API confirms this, he didn’t resign.
It’s not a “double games bug” case (I think everyone is aware of it, right?), we had only one game in that round.


Image

I got this error a lot (~10 times) in the last 2 days. It usually starts when I’m watching a game. Refreshing or clicking on another internal link doesn’t work, I have to change tab.
döskee found this bug too, but I asked in OGS chat and it doesn’t seem very common.

I know it says “our team has been notified of the bug” but I add it here just in case it’s false :slight_smile:

3 Likes

Is there any pattern to it? As soon as you watch, a capture, end of the game scoring etc?

I’m not sure exactly who would get the bug report. I can’t really tell what it says, but maybe some else can.

It happens every time that I try to open this game. I just noticed it, I didn’t know it before. I could play this game without any problem.
But this game happened some hours ago and I found this bug also before. I don’t remember what games caused it because I didn’t think it was caused by some specific games.

The error text from my smartphone seems a bit different:

Text

Congratulations, you found a bug!
Our team has been notified of the bug, however if you have more details you’d like to provide, please click here to fill out a report.
Cannot read properties of undefined (reading ‘x’)

at hc (https://cdn.online-go.com/5.1/ogs.5.1-3369-g02d5cf1b-01b36434f5757be9d6be0fd4c21e5af7.js:2:579622)
at div
at div
at div
at Fc (https://cdn.online-go.com/5.1/ogs.5.1-3369-g02d5cf1b-01b36434f5757be9d6be0fd4c21e5af7.js:2:619957)
at t (https://cdn.online-go.com/5.1/vendor.f459fb908b24daf3b08f8a1e0390f9e9.js:2:1055846)
at t (https://cdn.online-go.com/5.1/vendor.f459fb908b24daf3b08f8a1e0390f9e9.js:2:1056760)
at Da (https://cdn.online-go.com/5.1/ogs.5.1-3369-g02d5cf1b-01b36434f5757be9d6be0fd4c21e5af7.js:2:166823)
at div
at https://cdn.online-go.com/5.1/ogs.5.1-3369-g02d5cf1b-01b36434f5757be9d6be0fd4c21e5af7.js:2:1116673
at t (https://cdn.online-go.com/5.1/vendor.f459fb908b24daf3b08f8a1e0390f9e9.js:2:1053185)
at https://cdn.online-go.com/5.1/ogs.5.1-3369-g02d5cf1b-01b36434f5757be9d6be0fd4c21e5af7.js:2:1213481
5 Likes

That one is likely my fault. I’ll have a look at fixing it! Apologies!

5 Likes

Thanks shinuito, and don’t worry :slight_smile:
I found another game that gives me this error, this one.

3 Likes

I meant to say that @benjito fixed that one while I was asleep :slight_smile: Let us know if you find any other issues like that and apologies again for messing it up!

2 Likes

I can add that it’s not browser or computer- related. It just happened on my smartphone too :


this is not my game against Hampe.

2 Likes

I’ve seen this too. Unfortunately I don’t know what causes it.

Do you know steps that can consistently reproduce the issue? That’s probably the biggest hurdle in finding a solution…

1 Like

No, I didn’t find a way to reproduce it yet, I’m sorry.
My impression is that it’s a bit less frequent now than when I wrote the first message, but it still happens.

1 Like

Nice goban

3 Likes

I may have discovered something on the beta site.
I have 3 games there but only 2 of them cycle: a game against benjito and a rengo in which the next players are me and Venezia. I’m white in both of them.
If I repeatedly click on the 0 of the correspondence moves, sometimes in the game against benjito it shows me Venezia instead of benjito. The opposite has never happened.
Other times, I see Venezia for a very short time (after that the game has changed) and then it is changed to benjito.

I don’t know if this helps, I hope so :slightly_smiling_face:


Screenshots


https://online-go.com/game/38705001

https://beta.online-go.com/game/11324

I also noticed that the also the game info (before refreshing) also show the wrong player. Maybe it was obvious but I never checked it before.

3 Likes

I think I have seen similar things from time to time with that circling thing - it’s on the list of “need to look into”.

In general, could you report Rengo bugs in a different place - we might need a specific thread for this, or under Rengo Status could be OK. Then I will be sure to see them - I’m not necessarily looking in here often.

1 Like

I don’t think it’s a rengo related bug: it has never happened in a rengo game (to me) so far.
On the beta site, I had (and can reproduce) it only in the game against benjito, that is 1 vs 1.

Edit: Maybe you were referring to the fact that I can’t reach one of the games by clicking on the 0. In that case you are right, I’m sorry. I think I’ve already said this somewhere (our rengo chat, probably) anyway.

2 Likes

I re-use this topic :slight_smile:


This is what I see if I pause a live game when playing from my phone and it looks reproducible. The graphics are normal if it’s my opponent that pauses the game or if I pause a correspondence game. Refreshing solves it

I think I may have found the cause of this one (the players cards show the wrong players)

It seems there is a race condition when clicking through multiple games quickly. This is how it usually works (no bug):

  1. request details for game A
  2. receive and render details for game A
  3. request details for game B
  4. receive and render details for game B

In rare cases, the order of these is switched around so that you will see game A player details when you are on Game B’s page:

  1. request details for game A
  2. request details for game B
  3. receive and render details for game B
  4. receive and render details for game A

You had mentioned that this doesn’t generally happen for rengo games. This kind of makes sense because rengo details generally take slightly longer to load than non-rengo details, so it’s unlikely (but not impossible) that game B will load first if it is a rengo game.

I haven’t implemented a fix, but it should be fairly simple:

  1. request details for game A
  2. cancel any ongoing requests for game A
  3. request details for game B
  4. receive and render details for game B

I’ll leave an update when I have a chance to get this fix in :slight_smile:

EDIT: fix is in, thanks @anoek for implementation and @_Sofiam for testing!

3 Likes

Oh, thank you!
I see (or better, I notice) it a lot less often lately actually :slight_smile:
I thought it was related to this, which I think happens when two players accept a game almost simultaneously, but apparently not.
Something similar happens with profiles sometimes, some pieces are exchanged.

1 Like