Zero game waiting

BHydden · September 11, 2019, 2:56am

On its way

Auto-advance jumps from the your-turn tree into the active-games tree

opened 10:12PM - 10 Sep 19 UTC

closed 01:48PM - 16 Sep 19 UTC

**Describe the bug** Post-implementation of PR - #852 it was discovered that th…e "auto-advance" feature would automatically move a player from their last played move to their first active game. **To Reproduce** Steps to reproduce the behavior: 1. Have Auto Advance turned on and multiple correspondence games, in which at least one is your turn 2. Play a move in all the games that it is your turn 3. See that after your last move is played the server still auto advances you into the new all active games tree. **Expected behavior** Auto-advance should only move you to a game if it is your turn to move in that game. Progressing into the all-active-games tree should be a purely manual decision. **Additional context** For the life of me, I can't find where the auto-advance class lives in order to fix this 🤦‍♂ The issue was first reported in [this forum post](https://forums.online-go.com/t/zero-game-waiting/22781/21) and the 3 following comments.

brylie · September 11, 2019, 6:29pm

Edit:: I am also experiencing the bug mentioned above

It would also be somewhat nice to turn this “zero moves available” feature off, as I am not sure of the informational value of the icon. E.g. we usually only see notification icons when there is something to be notified of, like new messages or available moves.

I do appreciate the work going into OGS, but just want to add my two cents regarding the UX of this feature

Julko · September 12, 2019, 5:54am

I also want to have this possibility to turn this feature off (and on also).

BHydden · September 12, 2019, 6:02am

It’s not so much the informational value as the functional value. Are you aware that clicking on this button allows you to quickly cycle through your games?

This request will be considered. Currently, my top priority for this feature is fixing the auto-play interaction, which turned out to be slightly more complicated than I initially expected.

flovo · September 12, 2019, 6:51am

The CSS class of the 0 turn-indicator is .count.inactive. You can hide it with any good adblocker- or css-modification-plugin.

BHydden · September 12, 2019, 7:43am

Great tip! By far the easiest solution to implement

Mulsiphix1 · September 12, 2019, 1:31pm

Just to be helpful, I use uBlock Origin. In case anyone else does, add this to “My Filters” in the options or use the Element Picker Mode (eye dropper icon) to select any element and then overwrite what shows up in the filter box with this text instead.

##.count.inactive

BHydden · September 15, 2019, 8:38am

@AdamR pending anoek approval this should be good to go